Fix: add missing enable_tensor_type for CartesianLeviCivitaTensor and fix Levi-Civita size() #578 by Quntized · Pull Request #579 · gyselax/gyselalibxx

Quntized · 2026-03-06T11:25:57Z

src/coord_transformations/static_tensors.hpp:

Bug fix: Add missing enable_tensor_type specialization for
CartesianLeviCivitaTensor.
Bug fix: Fix size() in both CartesianLeviCivitaTensor and
LeviCivitaTensor. The previous implementation returned rank() * rank()
for just rank = 2;
Improvement: Use ddc::type_seq_element_t<dim, index_set> for
IdentityTensor::vector_index_set_t,
Improvement: Use ElementType instead of hardcoded double as the
return type of ddcHelper::get overloads for special tensors.
Doc fix: Correct ddcHelper::get doc comments
"modifiable reference" when the functions return by value.

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
Have you updated the CHANGELOG.md ?
Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
Have you checked that the AUTHORS file is up to date ?
Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
Do you follow the conventions specified in our coding standards ?

New Feature Submissions

Have you added tests for the new functionalities ?
Have you documented the new functionalities:
- API documentation describing the available methods, when each should be used and how to use them ?
- User-friendly documentation in README files (which may link to the API documentation).
- If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

Have you checked that existing tests cover all code after the changes ?
Have you checked that existing tests are still passing ?
Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

EmilyBourne

This looks great, but I think at least one extra test would be nice. To tests a different ElementType and maybe to show why CartesianLeviCivitaTensor needs to be enabled as a tensor type

codecov · 2026-03-06T17:26:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

… fix size() clang format, recognised, unauthorized character fixed. space correct

EmilyBourne · 2026-03-09T17:57:17Z

@Quntized Commits are squashed when we merge so it is not important to preserve a clean commit history. By force pushing your changes down to 1 commit all you are doing is:

Making it harder for me to see when review comments have been addressed
Forcing me to rerun the tests (wasting energy running the same tests multiple times)
Delaying the merge of the branch

Quntized · 2026-03-09T18:03:02Z

@EmilyBourne Thanks for the clarification! I didn't realize commits are squashed on merge — I'll just push new commits going forward instead of force-pushing. Sorry for the extra CI runs.

EmilyBourne · 2026-03-10T10:06:29Z

@tpadioleau @AbdelhadiKara could someone check that this doesn't cause any problems on GPU before I merge please? My WiFi isn't stable enough to use the vpn

AbdelhadiKara · 2026-03-10T10:10:18Z

@tpadioleau @AbdelhadiKara could someone check that this doesn't cause any problems on GPU before I merge please? My WiFi isn't stable enough to use the vpn

yes,

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

AbdelhadiKara · 2026-03-10T10:50:05Z

@EmilyBourne, The tests pass on the V100 architecture, only the simulations related to XVx geometry fail, it is not related to this MR I think. (python tkinter issues)

…-improvement

…untized/gyselalibxx into fix/static-tensors-improvement

Quntized · 2026-03-11T18:19:17Z

@tpadioleau fixed the changes that you suggested and also added in CHANGELOG.md. Let me know if everything looks alright.

EmilyBourne

Thomas is on holiday. But I agree that his comments have been addressed. I confirm that the code runs and compiles without warnings on GPU

… fix Levi-Civita size() #578 (#579) `src/coord_transformations/static_tensors.hpp`: 1. **Bug fix**: Add missing `enable_tensor_type` specialization for `CartesianLeviCivitaTensor`. 2. **Bug fix**: Fix `size()` in both `CartesianLeviCivitaTensor` and `LeviCivitaTensor`. The previous implementation returned `rank() * rank()` for just rank = 2; 3. **Improvement**: Use `ddc::type_seq_element_t<dim, index_set>` for `IdentityTensor::vector_index_set_t`, 4. **Improvement**: Use `ElementType` instead of hardcoded `double` as the return type of `ddcHelper::get` overloads for special tensors. 5. **Doc fix**: Correct `ddcHelper::get` doc comments "modifiable reference" when the functions return by value. --------- Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

EmilyBourne requested changes Mar 6, 2026

View reviewed changes

Comment thread src/data_types/static_tensors.hpp Outdated

Quntized force-pushed the fix/static-tensors-improvement branch 3 times, most recently from e7ee10e to ab6925c Compare March 6, 2026 16:10

Quntized had a problem deploying to GitLab GPU trigger March 6, 2026 16:16 — with GitHub Actions Failure

Quntized force-pushed the fix/static-tensors-improvement branch 2 times, most recently from e6a2fd2 to 54eabf7 Compare March 6, 2026 16:44

EmilyBourne had a problem deploying to GitLab GPU trigger March 6, 2026 17:07 — with GitHub Actions Error

Quntized force-pushed the fix/static-tensors-improvement branch from b3f35eb to 1e86e55 Compare March 6, 2026 17:57

Quntized had a problem deploying to GitLab GPU trigger March 9, 2026 07:25 — with GitHub Actions Error

Quntized force-pushed the fix/static-tensors-improvement branch from 9bed90a to b29dfca Compare March 9, 2026 16:52

EmilyBourne reviewed Mar 9, 2026

View reviewed changes

Comment thread src/data_types/static_tensors.hpp Outdated

Quntized had a problem deploying to GitLab GPU trigger March 9, 2026 17:19 — with GitHub Actions Error

EmilyBourne approved these changes Mar 9, 2026

View reviewed changes

Quntized had a problem deploying to GitLab GPU trigger March 9, 2026 17:31 — with GitHub Actions Error

Quntized force-pushed the fix/static-tensors-improvement branch from 8f0c7ab to b570382 Compare March 9, 2026 17:37

Fix: add missing enable_tensor_type for CartesianLeviCivitaTensor and…

0310308

… fix size() clang format, recognised, unauthorized character fixed. space correct

Quntized force-pushed the fix/static-tensors-improvement branch from b570382 to 0310308 Compare March 9, 2026 17:51

Quntized had a problem deploying to GitLab GPU trigger March 9, 2026 17:59 — with GitHub Actions Error

tpadioleau requested changes Mar 10, 2026

View reviewed changes

Comment thread src/data_types/static_tensors.hpp Outdated

Comment thread src/data_types/static_tensors.hpp Outdated

Quntized and others added 2 commits March 10, 2026 16:18

Update src/data_types/static_tensors.hpp

e9f640c

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

Update src/data_types/static_tensors.hpp

f938396

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

EmilyBourne requested a review from tpadioleau March 10, 2026 11:27

Quntized had a problem deploying to GitLab GPU trigger March 10, 2026 11:28 — with GitHub Actions Error

Quntized and others added 5 commits March 11, 2026 14:41

Merge branch 'devel' into fix/static-tensors-improvement

ef4f8a2

Merge branch 'devel' into fix/static-tensors-improvement

65a898b

Merge remote-tracking branch 'upstream/devel' into fix/static-tensors…

a1335e4

…-improvement

Added CHANGELOG.md in fixed section

7d5b3bc

Merge branch 'fix/static-tensors-improvement' of https://github.com/Q…

aeb575d

…untized/gyselalibxx into fix/static-tensors-improvement

Quntized had a problem deploying to GitLab GPU trigger March 17, 2026 09:33 — with GitHub Actions Failure

EmilyBourne approved these changes Mar 17, 2026

View reviewed changes

EmilyBourne merged commit ea466c2 into gyselax:devel Mar 17, 2026
25 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: add missing enable_tensor_type for CartesianLeviCivitaTensor and fix Levi-Civita size() #578#579

Fix: add missing enable_tensor_type for CartesianLeviCivitaTensor and fix Levi-Civita size() #578#579
EmilyBourne merged 8 commits into
gyselax:develfrom
Quntized:fix/static-tensors-improvement

Quntized commented Mar 6, 2026 •

edited by EmilyBourne

Loading

Uh oh!

EmilyBourne left a comment

Uh oh!

Uh oh!

codecov Bot commented Mar 6, 2026

Uh oh!

Uh oh!

EmilyBourne commented Mar 9, 2026 •

edited

Loading

Uh oh!

Quntized commented Mar 9, 2026 •

edited

Loading

Uh oh!

EmilyBourne commented Mar 10, 2026

Uh oh!

AbdelhadiKara commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

AbdelhadiKara commented Mar 10, 2026

Uh oh!

Quntized commented Mar 11, 2026

Uh oh!

EmilyBourne left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Quntized commented Mar 6, 2026 • edited by EmilyBourne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions

New Feature Submissions

Changes to Existing Features

Changes to the CI

Uh oh!

EmilyBourne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Mar 6, 2026

Codecov Report

Uh oh!

Uh oh!

EmilyBourne commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Quntized commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmilyBourne commented Mar 10, 2026

Uh oh!

AbdelhadiKara commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

AbdelhadiKara commented Mar 10, 2026

Uh oh!

Quntized commented Mar 11, 2026

Uh oh!

EmilyBourne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Quntized commented Mar 6, 2026 •

edited by EmilyBourne

Loading

EmilyBourne commented Mar 9, 2026 •

edited

Loading

Quntized commented Mar 9, 2026 •

edited

Loading